chore: remove deprecated UI settings extension from adk-ts and adk-ui#149
Open
PetrBulanek wants to merge 4 commits intomainfrom
Open
chore: remove deprecated UI settings extension from adk-ts and adk-ui#149PetrBulanek wants to merge 4 commits intomainfrom
PetrBulanek wants to merge 4 commits intomainfrom
Conversation
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
Signed-off-by: Petr Bulánek <bulanek.petr@gmail.com>
rubambiza
reviewed
Mar 27, 2026
rubambiza
left a comment
rubambiza
left a comment
There was a problem hiding this comment.
Clean removal — the commit structure is nice (remove, refactor, simplify, docs). The React state simplification in AgentDemandsProvider is a good win beyond just the deprecation cleanup.
You've likely already noticed, but CI is failing due to a stale pnpm-lock.yaml:
Update your lockfile using "pnpm install --no-frozen-lockfile"
This is causing the mise check, mise adk-server:test:e2e, and Dependency Review failures. A pnpm install and lock file commit should clear it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/settings/v1extension fromadk-tsandadk-ui, completing the cleanup started in Chore: remove deprecated settings extension from adk-py #118 (Python SDK)selectedSettingsReact state — settings values now have a single source of truth viaformFulfillmentsRefAgentDemandsProviderLinked Issues
Closes: #148
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.